Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€:: (#59) 메뉴 μ„œλΉ„μŠ€ μΈν„°νŽ˜μ΄μŠ€ #60

Merged
merged 23 commits into from
May 11, 2022
Merged

πŸ”€:: (#59) 메뉴 μ„œλΉ„μŠ€ μΈν„°νŽ˜μ΄μŠ€ #60

merged 23 commits into from
May 11, 2022

Conversation

iqpizza6349
Copy link
Member

close #59

iqpizza6349 added 11 commits May 5, 2022 01:28
@iqpizza6349
πŸ’₯:: (#59) Class λͺ… camelCase 둜 μˆ˜μ •
0c95acb
@iqpizza6349
πŸ–‹οΈ:: (#59) Menu μ—”ν‹°ν‹° λ‚΄λΆ€ μ˜ˆμ™Έ 클래슀 생성
06681f0
@iqpizza6349
πŸ’₯:: (#59) Menu λͺ¨λ“  메뉴 κ°€μ Έμ˜€κΈ° 주상화 λ©”μ†Œλ“œ 생성
33c1867
@iqpizza6349
πŸ’₯:: (#59) Menu 쀑볡 DTO, MenuCertainDto.java μ‚­μ œ
99a6284
@iqpizza6349
♻️:: (#59) MenuCreationDto.java ν•„λ“œ menuName 에 JsonProperty μΆ”κ°€
06d8c5a
@iqpizza6349
πŸ–‹οΈ:: (#59) 메뉴 좔상화 μ„œλΉ„μŠ€μ— javadoc 및 λ©”μ†Œλ“œ μΆ”κ°€
36d65a6
@iqpizza6349
πŸ–‹οΈ:: (#59) 메뉴 μ˜ˆμ™Έ 클래슀 μΆ”κ°€
eafd127
@iqpizza6349
πŸ“:: (#59) 메뉴 μ„œλΉ„μŠ€ μΈν„°νŽ˜μ΄μŠ€ javadoc 에외 μΆ”κ°€
b011d99
@iqpizza6349
πŸ–‹οΈ:: (#59) 메뉴 μ„œλΉ„μŠ€ νˆ¬ν‘œ μΆ”κ°€ 및 μ·¨μ†Œ λ©”μ†Œλ“œ μΆ”κ°€
9a09fa3
@iqpizza6349
♻️:: (#59) 메뉴 μƒνƒœ DTO ν•„λ“œ λ³€κ²½ 및 λͺ…λͺ…κ·œμΉ™μ— 따라 클래슀λͺ… λ³€κ²½
e98f700
@iqpizza6349
πŸ”€:: (#59) 메뉴 μƒνƒœ μ„€μ • λ©”μ†Œλ“œ μΆ”κ°€
82ad37d
@iqpizza6349 iqpizza6349 added CHORE Something little changes DOCS Changes to document FEAT New feature or request REFACTOR Refactoring is needed labels May 5, 2022
@iqpizza6349 iqpizza6349 self-assigned this May 5, 2022
@iqpizza6349
Copy link
Member Author

iqpizza6349 commented May 5, 2022 •
edited
Loading

SonarCloud Code Analysisμ—μ„œ λ°œμƒν•˜λŠ” 0.0% Coverage on New Code (is less than 80%) λ¬Έμ œλŠ” μ€‘λ³΅μ½”λ“œ ν˜Ήμ€ SonarCloud ν…ŒμŠ€νŠΈμ— ν¬ν•¨λ˜μ§€ μ•ŠλŠ” 경우 이 두가지가 λŒ€ν‘œμ μž…λ‹ˆλ‹€. κ·Έ 쀑 ν›„μžμΌ 경우 μ‹€μ§ˆμ μΈ μ½”λ“œμ— λ¬Έμ œλŠ” μ•„λ‹ˆκΈ° λ•Œλ¬Έμ— merge ν—ˆκ°€ν•΄μ£ΌλŠ” 편이 λ‚˜μ•„λ³΄μž…λ‹ˆλ‹€.
not covered by tests μ΄λΌλŠ” μ½”λ©˜νŠΈκ°€ μžˆλŠ” κ²½μš°κ°€ ν›„μžμ˜ κ²½μš°μž…λ‹ˆλ‹€.

@iqpizza6349 iqpizza6349 requested a review from a team May 5, 2022 16:05
@ericlee05
Copy link
Contributor

일단은 Sonarcloud의 new code 기쀀을 Number of daysμ—μ„œ Previous version으둜 λ³€κ²½ν•΄ λ³΄μ•˜μŠ΅λ‹ˆλ‹€. 이게 λ‹€μŒ analysisλΆ€ν„° λ°˜μ˜λ˜λŠ”μ§€λΌ 일단 이번 PRμ—μ„œλŠ” λ„˜μ–΄κ°€κ³ , λ‹€μŒ PRμ—μ„œλ„ fail λœ¨λ©΄μ€ λ§μ”€ν•˜μ‹  κ²ƒμ²˜λŸΌ merge ν—ˆκ°€ν•΄μ£ΌλŠ” λ°©ν–₯으둜 κ°€λŠ”κ²Œ 쒋을 κ±° κ°™μŠ΅λ‹ˆλ‹€.

ericlee05
ericlee05 requested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ericlee05 ericlee05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€ πŸ™

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.Β  Β  Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@iqpizza6349
Copy link
Member Author

ν˜„μž¬ μžˆλŠ” Fail은 not covered by tests μž…λ‹ˆλ‹€.

ericlee05
ericlee05 approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@ericlee05 ericlee05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ merge μ§„ν–‰ν•΄μ£Όμ„Έμš” πŸ‘οΈ

@iqpizza6349 iqpizza6349 merged commit c04ecd9 into main May 11, 2022
@ericlee05 ericlee05 deleted the Feature/#59-MenuService branch July 14, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericlee05 ericlee05 ericlee05 approved these changes

@krapoi krapoi krapoi approved these changes

Assignees

@iqpizza6349 iqpizza6349

Labels
CHORE Something little changes DOCS Changes to document FEAT New feature or request REFACTOR Refactoring is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu μ„œλΉ„μŠ€ 좔상화
3 participants
@iqpizza6349 @ericlee05 @krapoi