-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update envo-edit.owl #759
Update envo-edit.owl #759
Conversation
See also, ENVO:alpine tundra ecosystem, which is mapped to the SWEET:AlpineTundra SWEET class (FN 1). Footnotes1Somethings not quite right with the SWEET Tundra class, one of its subclass axioms is mangled: |
Conflicts have been detected, as another branch was active and merged before this one was attended to. Will resolve these soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - I made changes as reported in the discussion.
@@ -26,7 +26,7 @@ Import(<http://purl.obolibrary.org/obo/envo/imports/uberon_import.owl>) | |||
Import(<http://purl.obolibrary.org/obo/envo/modules/entity_attribute_location.owl>) | |||
Import(<http://purl.obolibrary.org/obo/envo/imports/chebi_import.owl>) | |||
Import(<http://purl.obolibrary.org/obo/envo/imports/iao_import.owl>) | |||
Annotation(<http://purl.org/dc/elements/1.1/creator> "http://orcid.org/0000-0002-4366-3088") | |||
Annotation(<http://purl.org/dc/elements/1.1/creator> <http://orcid.org/0000-0002-4366-3088>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing the nanocrediting APs in this PR, I've made a bunch of substitutions of old ORCIDs rendered as strings with IRIs. More to be done here in other PRs.
@@ -2942,6 +2942,7 @@ Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_01001621>)) | |||
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_01001622>)) | |||
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_01001623>)) | |||
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_01001624>)) | |||
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_01001625>)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and the accompanying stanzas in the Class section, was what was causing the conflict.
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#inSubset> <http://purl.obolibrary.org/obo/ENVO_00000112> "envoPolar") | ||
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_00000112> "tundra"^^xsd:string) | ||
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_00000112> "area of tundra"^^xsd:string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making more explicit that some classes are site-based. I added ecosystem equivalents as described in this PR's discussion.
for #739 - Adding two subtypes of tundra (alpine and polar). Please verify that I got the numbering correctly!