Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage & update action versions #1954

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 10, 2024

Hi there!
I looked into the lack of code coverage (e.g. in this CI log), and it turns out you're using a very outdated version of the Codecov action, which severely limits your uploads.
The solution is to update the action and add a secret CODECOV_TOKEN to the repo, following the procedure I described here: https://discourse.julialang.org/t/psa-new-version-of-codecov-action-requires-additional-setup/109857.
I used the opportunity to update other action versions.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (4d4c546) to head (96bff51).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   71.44%   71.56%   +0.11%     
==========================================
  Files          32       32              
  Lines       13849    13849              
==========================================
+ Hits         9895     9911      +16     
+ Misses       3954     3938      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Member

wsmoses commented Oct 11, 2024

@gdalle if I gave you relevant repo/org permissions (and let me know which ones) would you be able to setup the key?

@gdalle
Copy link
Contributor Author

gdalle commented Oct 11, 2024

Sure but it's literally a 15 second procedure and I explain it in great detail on the discourse post, so don't feel compelled to bring me along. I'd be honored though

@gdalle
Copy link
Contributor Author

gdalle commented Oct 11, 2024

The right way is to add an organization wide secret

@gdalle
Copy link
Contributor Author

gdalle commented Oct 11, 2024

And actually since we've seen a codecov report in the present PR, it looks like the setup already works?

@wsmoses
Copy link
Member

wsmoses commented Oct 11, 2024

Cool, okay will merge

@gdalle
Copy link
Contributor Author

gdalle commented Oct 15, 2024

Hi Billy! It seems like this is good to go?

@wsmoses wsmoses merged commit c0c5e51 into EnzymeAD:main Oct 15, 2024
11 of 24 checks passed
@gdalle gdalle deleted the gd/codecov branch October 15, 2024 22:07
@wsmoses
Copy link
Member

wsmoses commented Oct 16, 2024

@gdalle this is breaking CI with say "Error: Unable to resolve action julia-actions/cache@v4, unable to find version v4" for docs, etc

I'm going to revert and let you reopen with a fix.

wsmoses added a commit that referenced this pull request Oct 16, 2024
wsmoses added a commit that referenced this pull request Oct 16, 2024
gdalle added a commit to gdalle/Enzyme.jl that referenced this pull request Oct 17, 2024
@gdalle
Copy link
Contributor Author

gdalle commented Oct 17, 2024

done in #1977, sorry for the typo, it was v2 and not v4
using dependabot might help for these kinds of updates btw

wsmoses pushed a commit that referenced this pull request Oct 17, 2024
* Revert "Revert "Fix code coverage & update action versions (#1954)" (#1974)"

This reverts commit e2b0e41.

* Cache action versions

* More cache v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants