Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CIs to use julia-actions/install-juliaup #1987

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prbzrg
Copy link
Contributor

@prbzrg prbzrg commented Oct 19, 2024

Also replaced the actions/cache with julia-actions/cache.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (037dfed) to head (1ef67b4).
Report is 162 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1987      +/-   ##
==========================================
+ Coverage   67.50%   70.38%   +2.88%     
==========================================
  Files          31       33       +2     
  Lines       12668    14593    +1925     
==========================================
+ Hits         8552    10272    +1720     
- Misses       4116     4321     +205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Member

wsmoses commented Oct 19, 2024

what's the advantage of juliaup here? Also we should keep the names 1.10, 1.11, etc explicitly

@prbzrg
Copy link
Contributor Author

prbzrg commented Oct 19, 2024

juliaup is the recommended way to install and use Julia.
The benefits are few but IMHO, we should choose it over setup-julia.

@wsmoses
Copy link
Member

wsmoses commented Oct 19, 2024

…but for CI where versions are always fixed?

imo we should use whatever reduces setup latency since these jobs are run constantly.

cc @vchuravy if you have thoughts here

@prbzrg
Copy link
Contributor Author

prbzrg commented Oct 19, 2024

I looked into some CI runs, and it seems that install-juliaup is the faster setup. (12 seconds less)~
Both have similar setup time.

@wsmoses
Copy link
Member

wsmoses commented Oct 21, 2024

If that's the case I really don't see the value add here?

My understanding of juliaup is that essentially it's a script which download's the right julia version binary as required, then dispatches to that. Which, is all good for making users lives' easier.

But in this CI context, we'll never need that functionality, and it feels like it would add extra points of failure/latency, no?

@prbzrg
Copy link
Contributor Author

prbzrg commented Oct 23, 2024

I don't think it would be any more failures. but feel free to close this one.
If in the future, there were more points, we can open this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants