Add CI testing for EnzymeCore #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2009 +/- ##
==========================================
+ Coverage 67.50% 69.41% +1.90%
==========================================
Files 31 35 +4
Lines 12668 14920 +2252
==========================================
+ Hits 8552 10356 +1804
- Misses 4116 4564 +448 ☔ View full report in Codecov by Sentry. |
vchuravy
approved these changes
Oct 23, 2024
wsmoses
reviewed
Oct 23, 2024
| matrix: | ||
| version: | ||
| - '1.10' | ||
| - ~1.11.0-0 |
There was a problem hiding this comment.
I took the same versions as for EnzymeTestUtils, feel free to change those in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1979, this PR adds a CI job for testing EnzymeCore and reporting coverage, following the model of EnzymeTestUtils.
It also skips two tests which seem broken but were never run before so we didn't know.