Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The shared folder/folder id can also be a task list #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pro
Copy link

@Pro Pro commented Apr 21, 2016

If another user shares a task list with you, then you can add the task list through the Folder ID.
Therefore the folderClass can also be an IPF.Task

The rest of the plugin still works since calendar and tasks are the same.

@bavincen
Copy link

ahh ok! https://msdn.microsoft.com/en-us/library/bb176446%28v=office.12%29.aspx
Appointment class is Calendar item cant be a task

@bavincen bavincen closed this Apr 26, 2016
@Pro
Copy link
Author

Pro commented Apr 26, 2016

@bavincen sorry I don't understand your comment...
Can you clarify that?
Any reason why you didn't merge the commit?

@bavincen
Copy link

please give me some details what you commit will do.
changing one line will provide that feature?

@Pro
Copy link
Author

Pro commented Apr 26, 2016

Ok, I'll try my best:
Your EWS plugin allows to add shared folders by indicating the EWS ID of that folder.
E.g. another user can share his calendar with me. To add the calendar to Thunderbird I use the ID of the folder to add it.

The same can happen with a task list:
If another user shares a task list with me, I could take the EWS ID and add it to the tasks list in Thunderbird. At this point your EWS plugin fails. The folder class is IPF.Task and thus it fails with alert(this.globalFunctions.getString("calExchangeCalendar", "ecErrorServerAndMailboxCheck", [aMsg, aCode], "exchangecalendar")); (This error message will never be shown by the way, the plugin just hangs and does nothing).
With my change the shared task list is accepted. And since a Task List is handled exactly the same as Appointments, everything else works. I tested this on my Thunderbird installation and it works flawlessly.
There is no need to change any other line of code.

@Pro
Copy link
Author

Pro commented May 3, 2016

@bavincen any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants