Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI provider detection for .dacpac #2862

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Improve CLI provider detection for .dacpac #2862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Core/RevEng.Core.80/ConnectionStringResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Data.Common;
using System.IO;
Expand All @@ -14,6 +14,7 @@ namespace RevEng.Core
public class ConnectionStringResolver
{
private readonly string connectionString;
private readonly bool isDacpac;

public ConnectionStringResolver(string connectionString)
{
Expand All @@ -23,6 +24,7 @@ public ConnectionStringResolver(string connectionString)

if (connectionString.EndsWith(".dacpac", StringComparison.OrdinalIgnoreCase))
{
isDacpac = true;
var database = Path.GetFileNameWithoutExtension(connectionString);
this.connectionString = $"Data Source=(local);Initial Catalog={database};Integrated Security=true;Encrypt=false";
}
Expand All @@ -34,6 +36,12 @@ public IList<string> ResolveAlias()
{
var aliases = new List<string>();

if (isDacpac)
{
aliases.Add("mssql");
return aliases;
}

try
{
var a = new SqlConnectionStringBuilder(connectionString);
Expand Down