Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone Implementation #4

Draft
wants to merge 136 commits into
base: master
Choose a base branch
from
Draft

Standalone Implementation #4

wants to merge 136 commits into from

Conversation

Thatsmusic99
Copy link
Collaborator

@Thatsmusic99 Thatsmusic99 commented Jul 18, 2021 •
edited
Loading

Still being tested with HeadsPlus v7 so fairly incomplete. Closes #3.

This PR removes the full dependency on the Bukkit API and deprecates CMFile, which has been replaced with ConfigFile. There's still some bits and pieces that need re-adding but otherwise not much.

  • Re-add title API
  • Document MemorySection
  • Document ConfigSection
  • Work on wiki
  • Actually being a good programmer and commenting stuff
  • Polishing off general code quality and reducing duplicated code (if any)

@Thatsmusic99
Initial standalone commit
5d05cec
@Thatsmusic99
Added tests
ace01ce
@Thatsmusic99
Added interfaces
865c386
@Thatsmusic99
Bumped version
8e78ce3
@Thatsmusic99
Deprecated CMFile altogether
1413261
@Thatsmusic99
Added ConfigSection implementation
aedaa77
@Thatsmusic99
Added MemorySection implementation
a666d48
@Thatsmusic99
Added CommentWriter
32934e1
@Thatsmusic99
Replaced ConfigTests with a test of AT's
de7d954
@Thatsmusic99
Renamed InternalConfigFile to ConfigFile
ef00ed6
@Thatsmusic99
get rid of this, this sucks
44d4706
@Thatsmusic99
Add any pending comments to the parent section rather than actual option
d327dbd
@Thatsmusic99
Fixed addComment(String, String) only working for sections, not actua…
f624b1d 
…l options
@Thatsmusic99
Added ConfigSection#addComments(String, String...)
6767d0a
@Thatsmusic99
Throw IllegalStateException when trying to make a section where an op…
1712bf9 
…tion exists
@Thatsmusic99
Remove duplicating code in moveTo method
e727a0f
@Thatsmusic99
Add TODO for future release
c78812c
@Thatsmusic99
oh yeah bump the version
36ff653
@Thatsmusic99
Fixed ConfigFile#reload
f9b2d2e
@Thatsmusic99
Fixed comments not always getting fetched and placed properly
85d5a28
@Thatsmusic99
Fixed option paths not being determined correctly
ac0e7ae
@Thatsmusic99
Fixed ConfigSection#makeSectionLenient(String) not working properly
23148e8
@Thatsmusic99
Generify the maps here
e07cd79
@Thatsmusic99
Remove the option if the value specified is null
20c69e6
@Thatsmusic99
Moved API and Bukkit stuff into separate modules
de63db3
@Thatsmusic99
Added tests
d95b4de
@Thatsmusic99
Ignore all .yml files generated by tests
8d40c80
@Thatsmusic99
add a warning to own the libs
c181aec
@Thatsmusic99
Fixed dependency/imports that come from Bukkit
ed3eaab
@Thatsmusic99
Fixed null options being added
c4a2d05
Thatsmusic99 and others added 30 commits June 8, 2023 15:18
@Thatsmusic99
feat: add example annotations
c515fcb
@Thatsmusic99
fix: reloading duplicating comments
0f5fb2a
@Thatsmusic99
fix: this too
a35c4c3
@Thatsmusic99
fix: several API issues such as self-deleting sections and examples
d297950
@Thatsmusic99
fix: non-extended file handling overriding config content
7267d2f
@Thatsmusic99
chore(version): bump
6bfaab8
@Thatsmusic99
fix: error when deleting files and reloading
c7dd28e
@Thatsmusic99
fix: put lenient sections in the right place
19ba091
@Thatsmusic99
fix: don't bring back old sections after a reload
47056d8
@Thatsmusic99
chore(version): bump
054a6fd
@Thatsmusic99
fix: create a new file when using loadConfig
0f1aa4a
@Thatsmusic99
fix: examples being forced when the parent section does not exist, bu…
5b04db0 
…t the parent of the parent section is lenient
@Thatsmusic99
chore(version): bump to v2.0.0-BETA-9
d9e7214
@Thatsmusic99
fix: sections not being marked as, well, sections
3c12d1a
@Thatsmusic99
Update API pom
75e5f74
@Thatsmusic99
Update it here too
5b9a37f
@Thatsmusic99
And this too
cec628e
@Thatsmusic99
And this too
5e3d9c7
@Thatsmusic99
On this fine day I thank SnakeYAML and Spigot for being so wonderful …
5211f45 
…to work with nah actually fuck this
@Thatsmusic99
Merge pull request #7 from Errored-Innovations/Thatsmusic99-patch-1
2a5bc15 
fix: codepoint increase
@Thatsmusic99
I’m editing on mobile have mercy for the love of god
cfa23de
@Thatsmusic99
fix: LoaderOptions in the wrong spot
c4a1b91
@Thatsmusic99
feat: add permitted classes for tag inspection
0d6c52f
@Thatsmusic99
chore(version): bump to v2.0.0-rc.1
1c79b68
@Thatsmusic99
fix: pending comments (and sections) being handled incorrectly
816f328
@Thatsmusic99
chore(version): bump to v2.0.0-rc.2
bb69324
@Thatsmusic99
chore(deps): bump annotations to 24.0.1
51bcbe2
@Thatsmusic99
chore(deps): bump junit to 4.13.2
e34c38e
@Thatsmusic99
feat: add ability to check options before being processed by the config
d3e3294
@Thatsmusic99
chore(version): bump to v2.0.0-rc.3
4070ca9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Move away from using bukkit api
1 participant
@Thatsmusic99