Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] mis_builder_kpi_code: add new module #69

Merged
merged 1 commit into from
May 2, 2024

Conversation

WesleyOliveira98
Copy link
Contributor

This module includes the option to fill in the code field when creating a KPI in the MIS Report Template. This code field will be visible in the MIS Report Preview in the first column and will also be included when exporting documents to PDF or XLSX formats.

Configure KPI Code in a MIS Report Template:
image
image

Preview Mode:
image

Exported PDF:
image

Exported XLSX:
image

cc: @marcelsavegnago @kaynnan @Matthwhy

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 22.65625% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 49.31%. Comparing base (50e09a9) to head (974aa48).

Files Patch % Lines
...uilder_kpi_code/report/mis_report_instance_xlsx.py 15.23% 89 Missing ⚠️
mis_builder_kpi_code/models/mis_report_instance.py 28.57% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0      #69      +/-   ##
==========================================
- Coverage   53.85%   49.31%   -4.54%     
==========================================
  Files          60       66       +6     
  Lines         752      880     +128     
  Branches      170      193      +23     
==========================================
+ Hits          405      434      +29     
- Misses        338      437      +99     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelsavegnago
Copy link
Contributor

marcelsavegnago commented Apr 29, 2024

@WesleyOliveira98 oq acha de submeter para OCA ? não o modulo mas sim a inclusão do campo já no modulo mis_builder?

@WesleyOliveira98 WesleyOliveira98 marked this pull request as ready for review April 30, 2024 18:43
@WesleyOliveira98
Copy link
Contributor Author

@marcelsavegnago não tenho certeza se faria muito sentido esse campo fazer parte do módulo em si, esse campo code e uma coluna a mais para ele eu entendo que é mais a necessidade do cliente mesmo, a gente sabe que não precisaria ter um campo e uma coluna a mais só para ter o código da conta separado, todos os relatórios MIS que montamos até então não tinha e sempre atendeu muito bem os demais clientes. Mas você que manda, se achar válido eu fecho essa PR e abro lá na OCA.

Copy link
Contributor

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelsavegnago marcelsavegnago merged commit d6e4fa8 into 14.0 May 2, 2024
4 of 6 checks passed
@marcelsavegnago marcelsavegnago deleted the 14.0-add-mis_builder_kpi_code branch May 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants