Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create mutation methods on QuorumProposalWrapper #4082

Open
pls148 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #4097
Open

Create mutation methods on QuorumProposalWrapper #4082

pls148 opened this issue Jan 24, 2025 · 0 comments · May be fixed by #4097
Assignees
@pls148

Comments

@pls148
Copy link
Contributor

pls148 commented Jan 24, 2025

Currently some of the dependencies on hotshot need to modify the proposal inside of QuorumProposalWrapper for testing. This is done by directly referencing the proposal field. This causes overcoupling to the layout of QuorumProposalWrapper and thus methods like view_number_mut() should be created to make this cleaner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pls148 pls148

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4082 add mutable accessors to QuorumProposalWrapper EspressoSystems/HotShot
1 participant
@pls148