Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4082 add mutable accessors to QuorumProposalWrapper #4097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pls148
Copy link
Contributor

@pls148 pls148 commented Jan 30, 2025

Closes #4082

This PR:

This PR does not:

Key places to review:

@pls148 pls148 requested a review from bfish713 as a code owner January 30, 2025 23:29
Copy link
Contributor

@jparr721 jparr721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why bother adding mutable and immutable accessors when we could just make all the fields pub? Seems like this is just adding indirection.

Copy link
Collaborator

@bfish713 bfish713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I feel like all these fields do not need mutable access

Copy link
Contributor

@ss-es ss-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not clear we need all of these, but no objection from me

I think QuorumProposalWrapper is really a HotShot-internal type, and it makes sense to me to leave the fields private (or pub(crate) at most)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mutation methods on QuorumProposalWrapper
4 participants