Set default nonempty block threshold to 80% in integration tests #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
force-pushed
the
ss/integration-test-nonempty-block-default
branch
from
b718d85 to
7225f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing really requiring that the transaction task is working in most tests. I think requiring 80% of blocks to be nonempty is a sensible default (and this can be lowered or disabled per-test if necessary).
This PR:
Renames
nonempty_block_thresholdtononempty_block_ratio, defaulting to 80% in tests. Additionally, a newnonempty_block_thresholdis added allowing you to specify both a minimum number of decided blocks and a minimum number of nonempty decided blocks.This PR does not:
Key places to review: