Epoch 1 is genesis epoch #4112
Merged
Epoch 1 is genesis epoch #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is not called at the moment but it's better to have it because otherwise the default genesis method returning 0 might be called by accident.
pls148
approved these changes
Feb 6, 2025
pls148
added a commit
that referenced
this pull request
Feb 6, 2025
* #4045 re-enable epochs tests with dynamic quora * Epoch 1 is genesis epoch (#4112) * #4045 re-enable epochs tests with dynamic quora * Remove Epoch 0 * Allow dead code for genesis method for EpochNumber The method is not called at the moment but it's better to have it because otherwise the default genesis method returning 0 might be called by accident. * Adjust test_genesis_epoch_from_version --------- Co-authored-by: pls148 <[email protected]> --------- Co-authored-by: lukaszrzasik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
genesismethod returning Epoch 1 forEpochNumber. This is currently dead code but I think it's better to have it in place so that the default method returning Epoch 0 is not used by accident.test_genesis_epoch_from_versionaccordinglyThis PR does not:
Key places to review: