Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3975 missing drop allows consensus writelock to persist across acqui… #4115

Merged
merged 1 commit into from
Feb 11, 2025
Merged

#3975 missing drop allows consensus writelock to persist across acqui… #4115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/task-impls/src/da.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions> DaTaskState<TYP
if let Err(e) = consensus_writer.update_saved_payloads(view_number, payload) {
tracing::trace!("{e:?}");
}
drop(consensus_writer);

// Optimistically calculate and update VID if we know that the primary network is down.
if self.network.is_primary_down() {
let consensus =
Expand Down
Loading