This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
hotshot/rc-0.5.81
#122
Closed
hotshot/rc-0.5.81
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,8 +22,15 @@ tide-disco = "0.9" | |||
| toml = "0.8" | |||
| tracing = "0.1" | |||
| vbs = "0.1.4" | |||
| tokio = { version = "1", default-features = false, features = [ | |||
There was a problem hiding this comment.
also what is the reason to just use tokio now and remove async-std?
There was a problem hiding this comment.
- We only have to support a single executor in HotShot
- It lets us use async primitives unsupported by the compatibility layer
- Development would no longer involve manually setting RUSTFLAGS everywhere
- It lets us migrate off of tide to a more modern Tokio-based framework (we can technically do this now if we rock
tokio1, but I think it's best to have everything on a single executor)
In addition to the above, Tokio is better maintained
sveitser
reviewed
Nov 14, 2024
|
Since #123 we are on 0.5.82 of hotshot, so seems reasonable to close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.