Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running a simple nitro node #47

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

ImJeremyHe
Copy link
Member

@ImJeremyHe ImJeremyHe commented Aug 22, 2024

Closes EspressoSystems/nitro-espresso-integration#206
Closes #26

This PR:

  • Run a simple nitro node sucessfully. Use a more elegant way to keep the config compatible with upstream
  • Add a smoke test for it
  • Add a .gitignore file

This is helpful when doing the migration test.

Key places to review:

  • test-node.bash
  • rollupcreator/Dockerfile

How to test this PR

./test-node.bash --init--force --simple

@ImJeremyHe ImJeremyHe changed the title Backwards compatible Fix running a simple nitro node Aug 22, 2024
@sveitser
Copy link
Collaborator

@ImJeremyHe I'm on mobile, so difficult to review. Does this support writing an espresso config for the simple node? We also need this for the upgrade test.

@sveitser
Copy link
Collaborator

I see it should be supported. Do you know if it works?

@ImJeremyHe
Copy link
Member Author

@sveitser
Do you mean running the test node with --simple and --espresso --latest-espresso-image?

@sveitser
Copy link
Collaborator

Yes

@ImJeremyHe ImJeremyHe merged commit 98187ea into integration Aug 22, 2024
4 checks passed
@ImJeremyHe ImJeremyHe deleted the backwards-compatible branch August 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nitro-testnode: Ensure the espresso variant works with --simple Fix the testnode with flag --init only
2 participants