Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(action-pad): remove unnecessary overflow css styling. #11349

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

driskull
Copy link
Member

Related Issue: N/A

Summary

  • removes overflow styling which is unnecessary

@driskull driskull requested a review from jcfranco January 21, 2025 21:15
@driskull driskull marked this pull request as ready for review January 21, 2025 21:15
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 21, 2025
@jcfranco
Copy link
Member

We could treat this as a refactor or chore since it's cleaning up styles. Otherwise, we can reopen #11261 and link it. cc @geospatialem

@driskull driskull changed the title fix(action-pad): remove unnecessary overflow css styling. refactor(action-pad): remove unnecessary overflow css styling. Jan 21, 2025
@driskull
Copy link
Member Author

Updated to use refactor for now

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 22, 2025
@driskull driskull merged commit 3a61027 into dev Jan 22, 2025
18 checks passed
@driskull driskull deleted the dris0000/action-pad-remove-overflow branch January 22, 2025 00:47
@nCastle1
Copy link

I believe the overflow-y:auto was necessary for the corner rounding to work on action pad. At 106, action-pad is no longer round. Was this style change intentional?

image

@driskull
Copy link
Member Author

@nCastle1 I believe that change is unintentional.

@jcfranco should we revert and apply overflow:hidden? overflow-y:hidden only makes sense when action pad is vertical.

driskull added a commit that referenced this pull request Jan 22, 2025
benelan added a commit that referenced this pull request Jan 24, 2025
* origin/dev: (34 commits)
  build: update browserslist db (#11339)
  build(deps): update dependency lint-staged to v15.4.1 (#11343)
  chore: release next
  feat(graph): add component tokens (#11355)
  chore: release next
  fix(popover, tooltip): drop relative-positioning to reduce risk of clipping (#11373)
  chore: release next
  fix(date-picker): no longer disable min/max value month in select menu (#11350)
  chore(icon): improve icon load error message (#11367)
  fix(date-picker): remove outline for header actions (#11369)
  chore: release next
  fix(carousel): Ensure correct `autoplay` display and animation (#11338)
  chore: release next
  fix(flow): process items on loaded (#11364)
  chore: release next
  fix(combobox, stepper, table): respect user hidden attribute (#10983)
  refactor(action-pad): restore rounded styling (#11358)
  test(combobox): avoid emitting change event for value property update (#11281)
  chore: release next
  refactor(action-pad): remove unnecessary overflow css styling. (#11349)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants