Merge pull request #454 from Esri/share-action

set share as action
Esri · Dec 6, 2023 · 1359aa8 · 1359aa8
2 parents 247f6fe + 2e0f6f1
commit 1359aa8
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 34 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -81,7 +81,7 @@
     "@esri/arcgis-rest-service-admin": "^3.4.2",
     "@esri/calcite-components": "2.0.0",
     "@esri/calcite-design-tokens": "2.0.0",
-    "@esri/instant-apps-components": "1.0.0-beta.157",
+    "@esri/instant-apps-components": "1.0.0-beta.163",
     "@esri/hub-common": "^12.37.1",
     "@esri/hub-initiatives": "^12.4.1",
     "@esri/hub-sites": "^12.6.0",

diff --git a/src/components/crowdsource-manager/readme.md b/src/components/crowdsource-manager/readme.md
@@ -157,6 +157,7 @@ graph TD;
   instant-apps-social-share --> calcite-popover
   instant-apps-social-share --> calcite-button
   instant-apps-social-share --> calcite-icon
+  instant-apps-social-share --> calcite-action
   calcite-modal --> calcite-scrim
   calcite-modal --> calcite-icon
   instant-apps-filter-list --> calcite-panel

diff --git a/src/components/layer-table/layer-table.css b/src/components/layer-table/layer-table.css
@@ -108,9 +108,6 @@ vaadin-grid-cell-content {
 .share-action {
   position: absolute;
   right: 0;
-  margin-top: 4px;
-  margin-inline-end: 4px;
-  margin-bottom: 4px;
 }
 
 html[dir="rtl"] .share-action {
@@ -125,6 +122,6 @@ html[dir="rtl"] .share-action {
 }
 
 .instant-app-share {
-  height: 42px !important;
+  height: 50px !important;
   display: inline-flex;
 }
diff --git a/src/components/layer-table/layer-table.tsx b/src/components/layer-table/layer-table.tsx
@@ -1103,6 +1103,7 @@ export class LayerTable {
           ref={el => this._shareNode = el}
           scale="m"
           shareButtonColor="neutral"
+          shareButtonType="action"
           socialMedia={this.shareIncludeSocial}
           view={this.mapView}
         />

diff --git a/src/components/layer-table/readme.md b/src/components/layer-table/readme.md
@@ -112,6 +112,7 @@ graph TD;
   instant-apps-social-share --> calcite-popover
   instant-apps-social-share --> calcite-button
   instant-apps-social-share --> calcite-icon
+  instant-apps-social-share --> calcite-action
   calcite-modal --> calcite-scrim
   calcite-modal --> calcite-icon
   instant-apps-filter-list --> calcite-panel