Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed initialization of types to support changes in accordion values #1088

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

MikeTschudi
Copy link
Member

If the types list is not re-initialized, no new accordion items are added to the list with a new set of values.

If the accordion is initialized really quickly--as in < 30ms--we don't see this problem. But with a longer delay, such as by delaying initialization via setTimeout or a data fetch, render is called twice in a row.

During the first call, types gets initialized and accordion items are created. During the second call, the existing accordion items are cleared, but no new ones are created because each new item type is already found in types.

@MikeTschudi MikeTschudi requested a review from jmhauck January 9, 2025 00:05
@MikeTschudi MikeTschudi merged commit 0be077e into develop Jan 9, 2025
5 checks passed
@MikeTschudi MikeTschudi deleted the handle-delayed-init branch January 9, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants