Changed initialization of types to support changes in accordion values #1088
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
types
list is not re-initialized, no new accordion items are added to the list with a new set of values.If the accordion is initialized really quickly--as in < 30ms--we don't see this problem. But with a longer delay, such as by delaying initialization via
setTimeout
or a data fetch,render
is called twice in a row.During the first call,
types
gets initialized and accordion items are created. During the second call, the existing accordion items are cleared, but no new ones are created because each new item type is already found intypes
.