Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporter components #419

Merged
merged 13 commits into from
Nov 13, 2023
Merged

reporter components #419

merged 13 commits into from
Nov 13, 2023

Conversation

jmhauck
Copy link
Collaborator

@jmhauck jmhauck commented Nov 6, 2023

R01

@jmhauck jmhauck requested a review from MikeTschudi November 9, 2023 21:48
MikeTschudi
MikeTschudi previously approved these changes Nov 9, 2023
Copy link
Member

@MikeTschudi MikeTschudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why comment-out the tests for the stub components? While the tests are trivial now, they can evolve with the evolution of the component.

@@ -5,7 +5,7 @@
name="viewport"
content="initial-scale=1,maximum-scale=1,user-scalable=no"
/>
<title>Crowdsource Reporter</title>
<title>New Public Notification</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "New Public Notification" in crowdsource-reporter.html?

@jmhauck
Copy link
Collaborator Author

jmhauck commented Nov 13, 2023

The commented out tests...I had been doing that until I was going to invest time in them. I plan to start on them for the upcoming release.

@jmhauck jmhauck merged commit 01f9840 into develop Nov 13, 2023
3 checks passed
@jmhauck jmhauck deleted the r-01-reporter branch November 13, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants