-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reporter components #419
reporter components #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why comment-out the tests for the stub components? While the tests are trivial now, they can evolve with the evolution of the component.
src/demos/crowdsource-reporter.html
Outdated
@@ -5,7 +5,7 @@ | |||
name="viewport" | |||
content="initial-scale=1,maximum-scale=1,user-scalable=no" | |||
/> | |||
<title>Crowdsource Reporter</title> | |||
<title>New Public Notification</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "New Public Notification" in crowdsource-reporter.html
?
The commented out tests...I had been doing that until I was going to invest time in them. I plan to start on them for the upcoming release. |
R01