Popup utils and display issue #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeTschudi going to push this through before I head out for the break. Would like a review still please. Will be happy to resolve anything that you may notice. |
MikeTschudi
reviewed
Dec 23, 2023
| @@ -573,7 +573,7 @@ export class CrowdsourceManager { | |||
| let sizeClass = ""; | |||
| switch (layoutMode) { | |||
| case ELayoutMode.HORIZONTAL: | |||
| sizeClass = `${this._isMobile && this._hideTable ? "height-full" : panelOpen ? "height-1-2" : "height-0"} width-full position-relative`; | |||
| sizeClass = `${this._isMobile && this.hideMap ? "height-0 " : panelOpen ? "height-1-2 display-grid" : "height-0"} width-full position-relative`; | |||
There was a problem hiding this comment.
Am I misreading this line? Expanded, I think that it is
if hideMap
height-0
else if panelOpen
height-1-2 display-grid
else
height-0And so It appears that this line is actually
if panelOpen
height-1-2 display-grid
else
height-0and hideMap is irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#452