Updated Reporter code #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Updated popupUtils - To resolve the Arcade expression involving map and layer - To use async executor - Updated related components using this utils
## Implemented - Working sample for Feature-list - Working sample for Layer-list - More than one attribute to list on separate lines
## Implemented - Emit event togglePanel - Removed extra code related to map container - Updated Sample to pass mobile prop and listen togglePanel event
|
@sumitzarkar can we avoid running the query again when we switch between mobile and desktop? |
jmhauck
approved these changes
Jan 18, 2024
| @@ -239,14 +274,19 @@ export class FeatureList { | |||
| */ | |||
| protected async queryPage(page: number): Promise<VNode[]> { | |||
There was a problem hiding this comment.
@sumitzarkar could you put this in queryUtils please?
There was a problem hiding this comment.
As the code in this function is more specifc to the workflow of feature-list component, nothing major to put in the utils which can be reused hence we have not added in utils.
Please let us know if any specifc part from this functions needs to be added in utils.
Seems like these queries are fired by the api as the map is resized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated popupUtils
Implemented code review comments from previous pull request
Updated Reporter for map view only prop