Delivery for Reporter Instant App - Sprint2 - AGOL-2024.R01 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Updated layer-list component - Make the feature count functionality configurable - Make the show next icon functionality configurable - Updated function name onLayerItemSelected _Note: These changes are implemented so that same component can be used for choose category list when create feature is clicked on layer list_
## Show feature details on map click
jmhauck
approved these changes
Jan 26, 2024
| * On Feature details change update the Layer title and the current selected layer id | ||
| * @param evt Event hold the details of current feature graphic in the info-card | ||
| */ | ||
| protected featureDetailsChanged(evt: any): void { |
There was a problem hiding this comment.
Avoid any lets use the event type here
|
|
||
| /** | ||
| * On map click do hitTest and get the clicked graphics of valid layers and show feature details | ||
| * @param event |
sumitzarkar
added a commit
that referenced
this pull request
Jan 29, 2024
## implemented - Fixed review comments from previous pull request -#500 - Optimized the code to create list of valid layers only once on layer-list loaded instead of doing it on each map click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented following items
Tested on following platforms:
Note: We are observing issue related to the highlight on map when user is navigated to layerList, we are working on the highlihgt issue and will deliver the fix in next code drop
QA Checklist:
QAChecklist-CrowdsourceReporter_Instant_App-AGOL2024-_Sprint2.xlsx
Test cases & Execution report:
ESRILG_-TestScenarios___TestCases_-CrowdsourceReporter-AGOL2024-_Sprint2.xlsx