review all uses of convertAlldayUtcToLocal #1470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmamane
commented
Oct 6, 2023
| Utils.convertAlldayUtcToLocal( | ||
| event.endTime, event.endTime.toMillis(), mTimeZone); | ||
| final t = new Time(); | ||
| event.startTime.set( |
There was a problem hiding this comment.
This one I'm less certain of; I'm not sure what exactly the rest of the code makes with event.startTime and event.endTime; maybe that bit of code should instead be:
long millis = Utils.convertAlldayUtcToLocal(
t, event.startTime.toMillis(), mTimeZone);
event.startTime.setTimeZone(mTimeZone);
event.startTime.set(millis);
and the same for event.endTime
lmamane
force-pushed
the
cADUTL_robustness_fix
branch
from
895abe8
to
4169e03
Compare
when it looks like the caller does not expect it
lmamane
force-pushed
the
cADUTL_robustness_fix
branch
from
4169e03
to
63a3219
Compare
|
Since #1469 was applied, rebase to that this PR shows as one commit instead of showing commits that are already applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request is one commit above #1469; it tries to proactively fix the same underlying issue everywhere convertAlldayUtcToLocal is used in a suspicious way.