Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-132 Move level-related calculations to LevelUtil. #132

Merged
merged 4 commits into from
Oct 25, 2023
Merged

GH-132 Move level-related calculations to LevelUtil. #132

merged 4 commits into from
Oct 25, 2023

Conversation

vLuckyyy
Copy link
Member

No description provided.

@vLuckyyy vLuckyyy changed the title Move level-related calculations to LevelUtil. GH-132 Move level-related calculations to LevelUtil. Oct 25, 2023
rchomczyk
rchomczyk approved these changes Oct 25, 2023
View reviewed changes
Copy link

@rchomczyk rchomczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after code reformatting

Rollczi
Rollczi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Rollczi Rollczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good. But I think the level calculations should be in the manager.

@vLuckyyy vLuckyyy merged commit 9f33cb7 into master Oct 25, 2023
2 of 3 checks passed
@vLuckyyy vLuckyyy deleted the move-level-calculate-to-util branch October 25, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imDMK imDMK imDMK approved these changes

@rchomczyk rchomczyk rchomczyk approved these changes

@Rollczi Rollczi Rollczi approved these changes

@Hyd3r1 Hyd3r1 Awaiting requested review from Hyd3r1

@P1otrulla P1otrulla Awaiting requested review from P1otrulla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vLuckyyy @Rollczi @rchomczyk @imDMK