Release v1.6.2 #66
Merged
Release v1.6.2 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to base our code of this
Using event handlers rather than observables to track scrolling If we debounce it, we can potentially call refresh a lot less
Per magento 2 bug: magento/magento2#8084
This will allow us to "cache" the offset rather than searching and calculating every time
MomentJs is really slow. Let's use Date() instead
Not sure why we're doing this so it's going bye bye
Let's not get too fancy and add more methods to the call stack than we have to...
This was slowing things down tremendously. We only want to call it on this page so we insert a block that outputs configuration changes to requirejs to "remap" dom-observer.js to our empty file
Still getting some errors because of this in 2.2.5
It makes it feel sluggish
…eline Timeline Performance boost: Round 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
See change log for details: #65