[Linesh][#23] Refactor: move position calculation methods to Game

EthanLin-TWer · Mar 19, 2017 · 497de9f · 497de9f
1 parent d7a51a3
commit 497de9f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/js/Player.js b/js/Player.js
@@ -39,12 +39,12 @@ export class Player extends Movable {
          }
          break
       case 'up':
-         if (this.y > Game.row(0)) {
+         if (Game.withinTopBoundary(this.y)) {
             this.move(0, -Game.CELL_HEIGHT)
          }
          break
       case 'down':
-         if (this.y < Game.row(5)) {
+         if (Game.withinBottomBoundary(this.y)) {
             this.move(0, Game.CELL_HEIGHT)
          }
          break

diff --git a/js/constants/game.js b/js/constants/game.js
@@ -24,5 +24,13 @@ export class Game {
    static withinRightBoundary(x) {
       return x < Game.col(Game.HORIZON_CELLS)
    }
+
+   static withinTopBoundary(y) {
+      return y > Game.TOP_BOUNDARY
+   }
+
+   static withinBottomBoundary(y) {
+      return y < Game.row(5)
+   }
 }