Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try not verifying tls #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try not verifying tls #3

wants to merge 1 commit into from

Conversation

maalur
Copy link

@maalur maalur commented Mar 14, 2023

No description provided.

Copy link
Member

@JZebra JZebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maalur what do you think about this?

I don't feel great about merging it. This creates a vulnerability to MITM attacks. It's not public facing though, so we have some security through obscurity. Have we tried other options?

@maalur
Copy link
Author

maalur commented Apr 13, 2023

@JZebra yea, it's not a great solution, but I couldn't figure out anything else at the time and the exposure is pretty low since it's just the slack connection.

I think there were SSL upgrades that went out recently and older libraries don't support the newer certificates. So we could try updating our ruby version and networking libraries to fix this. But we might be blocked on that due to the lita libraries not being maintained.

@JZebra
Copy link
Member

JZebra commented Apr 13, 2023

@maalur that sounds annoying. I'm being negligent but I think we can use this for now. Try to tackle the upgrade during a gardening week or I can put it into a devops sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants