Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add offline-ras synthesize output format #103

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Dec 17, 2024

PR Goal?

Add the ability to synthesize directly to readalong's Offline HTML format.

Fixes?

Enhancement to #102 to complete fixing EveryVoiceTTS/EveryVoice#439

Feedback sought?

test, and review code

Priority?

beta

Tests added?

yes

How to test?

everyvoice synthesize from-text  -O offline-ras -t "stuff and nonsense" -v <vocoder.cpkt> <fs2.ckpt>

and look at the synthesized readalong/*.html file.

"forget" the -v option and see a nice error message

Confidence?

pretty good

Version change?

it'll contribute to the minor we're working on.

Related PRs?

Coming soon to a PR near you...
EveryVoiceTTS/EveryVoice#608
ReadAlongs/Studio#256

@joanise joanise requested a review from roedoejet December 17, 2024 18:22
Copy link

semanticdiff-com bot commented Dec 17, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/cli/synthesize.py  74% smaller
  fs2/type_definitions.py  60% smaller
  fs2/tests/test_writing_callbacks.py  20% smaller
  fs2/prediction_writing_callback.py  18% smaller

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @joanise - thanks! I would request changing the offline-ras variable name to something with more continuity with the existing readalong output type. Either with both readalong-xml and readalong-html or just readalong for the html/offline and readalong-xml.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.97%. Comparing base (9549082) to head (ff1b0d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs2/prediction_writing_callback.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   46.13%   46.97%   +0.83%     
==========================================
  Files          22       22              
  Lines        1461     1486      +25     
==========================================
+ Hits          674      698      +24     
- Misses        787      788       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise force-pushed the dev.ej/ras-offline-html branch from d67aa51 to 17968ac Compare December 17, 2024 19:12
@joanise joanise requested a review from roedoejet December 17, 2024 19:13
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

And rename readalong -> readalong-xml for clarity, as suggested by @roedoejet
@joanise joanise force-pushed the dev.ej/ras-offline-html branch from 17968ac to ff1b0d0 Compare December 17, 2024 21:36
@joanise joanise merged commit ff1b0d0 into main Dec 17, 2024
4 checks passed
@joanise joanise deleted the dev.ej/ras-offline-html branch December 17, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants