-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add offline-ras synthesize output format #103
Conversation
Changed Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @joanise - thanks! I would request changing the offline-ras
variable name to something with more continuity with the existing readalong
output type. Either with both readalong-xml
and readalong-html
or just readalong
for the html/offline and readalong-xml
.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 46.13% 46.97% +0.83%
==========================================
Files 22 22
Lines 1461 1486 +25
==========================================
+ Hits 674 698 +24
- Misses 787 788 +1 ☔ View full report in Codecov by Sentry. |
d67aa51
to
17968ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks!
And rename readalong -> readalong-xml for clarity, as suggested by @roedoejet
17968ac
to
ff1b0d0
Compare
PR Goal?
Add the ability to synthesize directly to readalong's Offline HTML format.
Fixes?
Enhancement to #102 to complete fixing EveryVoiceTTS/EveryVoice#439
Feedback sought?
test, and review code
Priority?
beta
Tests added?
yes
How to test?
and look at the synthesized readalong/*.html file.
"forget" the -v option and see a nice error message
Confidence?
pretty good
Version change?
it'll contribute to the minor we're working on.
Related PRs?
Coming soon to a PR near you...
EveryVoiceTTS/EveryVoice#608
ReadAlongs/Studio#256