Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt automatic embedding table update for previous models #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roedoejet
Copy link
Member

Copy link

semanticdiff-com bot commented Feb 12, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/model.py  0% smaller

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (a4841c7) to head (dcfce61).

Files with missing lines Patch % Lines
fs2/model.py 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   44.11%   43.83%   -0.29%     
==========================================
  Files          25       25              
  Lines        1657     1670      +13     
==========================================
+ Hits          731      732       +1     
- Misses        926      938      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, I didn't expect it to be possible. I have a question, though, would doing preprocessing of new data with 0.3.0 and using it on a model trained with 0.2.0a1 actually work, or would it break anyway?

Comment on lines +309 to +310
f"""There were breaking changes to the handling of phonological features in version 1.2, introduced in version 0.3.0 of EveryVoice.
Your model is version {ckpt_version} and your model may not work as a result. Please downgrade to everyvoice 0.2.0."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants