Skip to content

Commit

Permalink
dev notes
Browse files Browse the repository at this point in the history
  • Loading branch information
EvoArt committed Jan 9, 2025
1 parent 10d24aa commit 5f8f145
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/classifier.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
# The position of the word in a sequence is ignored.
# Only the words occurring in the query contribute to the score.

# Most compute time is spent on assignment (largely within the bootstrapping process). This
# is where most effort should be spent, outside of ensuring correctness and usability.
# Memory usage is also worth looking at, to ensure that users can run the code in parallel
# across many threads without issues.

"""
The results returned by `assign_taxonomy`. Individual columns can be accessed by e.g. `my_result.Genus`,
and a list of column names can be accessed by `names(my_result)`. The result can
Expand Down Expand Up @@ -97,7 +102,8 @@ function naieve_bayes(seqs::Vector,refs::Vector,taxa ::Array,k, n_bootstrap,lp=f
end

function assign(seq_mask,log_probs)

# This dominates compute time. optimization of other parts of the code base which don't
# speed up the assignment function are largely redundant at this point.
cp_max = Float32(-Inf)
ind = 1
for i in eachindex(log_probs)
Expand Down

0 comments on commit 5f8f145

Please sign in to comment.