-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intergrated auth #36
Conversation
Don't worry about the branches. I have no clue what I am doing either ;) |
@PrzemyslawKlys I've been thinking, maybe I should remove the switch parameter and make it work like the native send-mailmessage where if no password is provided then intergrated auth is attempted automatically? Let me know what you think. Also please let me know if there is some other area that the code doesn't cover. |
Hi, I've been thinking about this topic and three things:
|
Tasks to do
|
2nd option can be tested with Devops, as there are tests running I believe. So if you don't see errors there on loading it should not be a problem, but i guess we should write some tests for email sending anyways. |
Any luck in finishing up those TODDO task? |
@PrzemyslawKlys I'm so sorry for my radio silence. Life is thankfully busy and I haven't yet found the extra moment to come back into this project and finish it up. But don't worry, I didn't forget about it and still hope to finish it up soonish. Regards, |
Just a reminder ;) |
This will not be needed once this PR is done: It basically translates Mailozaurr to C#, or at least that's the goal. Thank you for your efforts! |
In reference to #12
My apologies that it's not on a separate branch. I'm not a big git user (by far) and by the time I realized it should've been on it's own branch it was very hard for me to figure out how to roll back the commits and add them back into their own branch so I left it as is. If you feel it should use it's own branch let me know and I will work on doing it.
No code here is my own. I practically converted the code from jstedfast/MailKit#332 (comment) to PowerShell.
I think this code uses NTLM, maybe in the future if someone is brave enough Kerberos can be added as well.
The only test I did was the following which worked, there might be other scenarios that won't work.