Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev dependencies: credo, ex_doc, dialyxir #61

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

JuneKelly
Copy link
Contributor

Upgrade:

  • credo 1.7
  • ex_doc 0.30
  • dialyxir 1.3

This will close some of those pesky dependabot issues.

@JuneKelly
Copy link
Contributor Author

JuneKelly commented Jul 17, 2023

Incidentally, I think we have some (caching?) issues in CI:

image

This kind of failure was fixed in #60, and the tests all pass locally.
I'll look into this.

EDIT: I now wonder if the tests still fail sporadically in one of the environments in the test matrix, which I just now realised exists.

@epinault
Copy link
Contributor

Hm.. strange . 22.04 and latest elixir seems strange to fail

@epinault
Copy link
Contributor

maybe we just punt on 22.? because seems to be that 23 and 24 have been there long enough at this point

@JuneKelly
Copy link
Contributor Author

Sorry it's taken a while to get back to this, I've been busy 😅

Sure, I agree, let's just test on 23 and 24, if we can't figure this out easily.

@epinault epinault merged commit 07a4898 into master Aug 31, 2023
10 checks passed
@epinault epinault deleted the jk-dependency-upgrades-2023-07 branch August 31, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants