This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
BA-1131- Implement design changes to CWU proposal #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow immediate attachments
Did some minor styling here, but some logic changes are needed so that the alert linking to a submitted proposal persists even after the closing deadline.
after the closing deadline
and remove unnecessary buttons
- so that btn-outline has a border for use of the Upload a file button in cwu-proposal
- remove banner above header - customize title depending on whether proposal is submitted or not - add alerts below title depending on status - remove delete button from footer - show footer with submit button only until proposal is submitted - restyle submit button
- restyle tables and buttons - replace alerts with heading
- add heading - restyle alert - make heading and checkbox disappear upon accepting the terms, replace with confirmation message
after uploading files
after closing deadline
- make DRAFT badge appear even after deadline has passed - add message explaining that proposal was not submitted after deadline has passed - make attachments CTA and button appear only after user has accepted the terms - change submit button back to a block (now that we're using a narrower modal)
… still in draft after closing deadline
|
@mark-a-wilson is this okay to merge? Are you still working on the UI? |
|
It's been a while since I've checked, but I think I finished all the UI fiddling I wanted to do. It's going to break the the functional tests, anyway though, isn't it? |
|
Functional tests are not currently functional anyway. I can merge this to dev |
|
😂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(proposals): Implement design changes to CWU proposal
Do not merge upon approving this PR as additional changes may be needed
Fixes BA-1131 (BA-1158, BA-1159, BA-1160)