-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary field (backport #3137) #3139
Conversation
Cherry-pick of db8b8c2 has failed:
Cherry-pick of 03bdced has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
find_if is too heavy to use here. Signed-off-by: Rosen Penev <[email protected]> (cherry picked from commit 289eb76)
(cherry picked from commit db8b8c2)
(cherry picked from commit b2fdeca)
(cherry picked from commit 03bdced)
16e1d8b
to
5173509
Compare
@kevinbackhouse @nehaljwani Any appetite for a 0.28.4 release? |
Yes, I can help with that. |
Remove
CiffDirectory::cc_
. It's a raw pointer, so it's ownership is unclear. There also doesn't seem to be any reason to store it in the object.This is an automatic backport of pull request #3137 done by Mergify.