Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson CI: Add OmniOS #3196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

meson CI: Add OmniOS #3196

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 28, 2025

There's solaris code in here that's pretty much untested. Might as well do so.

CI is meson only currently. Added CMake support anyway. Cleaned up surrounding code.

There's solaris code in here that's pretty much untested. Might as well
do so.

CI is meson only currently. Added CMake support anyway. Cleaned up
surrounding code.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented Feb 28, 2025

  ../samples/geotag.cpp: In function 'int main(int, const char**)':
  ../samples/geotag.cpp:815:14: warning: unnecessary parentheses in declaration of 'program' [-Wparentheses]
    815 |     ::version(program);
        |              ^~~~~~~~~
  ../samples/geotag.cpp:815:14: note: remove parentheses
    815 |     ::version(program);
        |              ^~~~~~~~~
        |              -       -
  ../samples/geotag.cpp:815:15: warning: unused variable 'program' [-Wunused-variable]
    815 |     ::version(program);
        |               ^~~~~~~
  ../samples/geotag.cpp: At global scope:
  ../samples/geotag.cpp:630:5: warning: 'int {anonymous}::version(const char*)' defined but not used [-Wunused-function]
    630 | int version(const char* program) {
        |     ^~~~~~~

that's just weird.

@neheb neheb requested a review from kmilos March 1, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants