Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix privacy policy #217

Merged
merged 8 commits into from
May 26, 2024
Merged

Fix privacy policy #217

merged 8 commits into from
May 26, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

Fixes #216

image

Let's find the best formulation

@codeurimpulsif
Copy link
Contributor

What is application ID? Is it more clear if we say application handle and version number?

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented May 19, 2024 •
edited
Loading

Version number is not send to the server
Ok to use application handle

@codeurimpulsif
Copy link
Contributor

Ok, so yes I think application handle is a better term and it's the one used everywhere in our website and documentation.

codeurimpulsif
codeurimpulsif approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me, I hope for Google too!

@Jean-BaptisteC
Copy link
Contributor Author

Jean-BaptisteC commented May 26, 2024 •
edited
Loading

Changes in french pushed
v.3.3.0 version is ready for exam on Play Store

@Jean-BaptisteC Jean-BaptisteC marked this pull request as ready for review May 26, 2024 19:33
@Jean-BaptisteC
Copy link
Contributor Author

Ready to merge

@Jean-BaptisteC Jean-BaptisteC merged commit bb6b3fe into main May 26, 2024
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the pp branch May 26, 2024 20:42
@Jean-BaptisteC
Copy link
Contributor Author

@codeurimpulsif website is updated automatically?
I didn't seen my changes

@codeurimpulsif
Copy link
Contributor

@Jean-BaptisteC a git divergence was stucking the build, I just fix it!

@Jean-BaptisteC
Copy link
Contributor Author

Thanks, I push changes in Google console tonight

@Jean-BaptisteC
Copy link
Contributor Author

Google has refused again updates :(

@codeurimpulsif
Copy link
Contributor

Again? What do they want?

@Jean-BaptisteC
Copy link
Contributor Author

The same thing, I don't know how to resolve this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Porkepix Porkepix Porkepix left review comments

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

@jfoucry jfoucry Awaiting requested review from jfoucry

@pnu-s pnu-s Awaiting requested review from pnu-s

@DavidLibeau DavidLibeau Awaiting requested review from DavidLibeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update privacy policy to unlock publication release on GP
3 participants
@Jean-BaptisteC @codeurimpulsif @Porkepix