Expiration will be 0 when the S3 lifecycle rule is disabled (#301)

ExpediaGroup · Feb 26, 2025 · d6486d4 · d6486d4
1 parent 66c550e
commit d6486d4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.9.6] - 2025-02-26
+### Fixed
+- Expiration will be 0 when the S3 lifecycle rule is disabled.
+
 ## [7.9.5] - 2025-02-26
 ### Added
 - Add option to provision glue databases using terraform instead of metastore startup.

diff --git a/s3.tf b/s3.tf
@@ -96,13 +96,13 @@ resource "aws_s3_bucket_lifecycle_configuration" "apiary_data_bucket_versioning_
       storage_class = each.value["s3_storage_class"]
     }
   }
-  # Rule s3 object expiration
+  # Rule s3 object expiration - days cannot be negative
   rule {
     id     = "cost_optimization_expiration"
     status = each.value["s3_object_expiration_days_num"] != "-1" ? "Enabled" : "Disabled"
 
     expiration {
-      days = each.value["s3_object_expiration_days_num"]
+      days = each.value["s3_object_expiration_days_num"] != "-1" ? each.value["s3_object_expiration_days_num"] : "0"
     }
   }
 }