chore: Remove cli. Update dependencies #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamespfaulkner
commented
Nov 27, 2023
| @@ -53,10 +53,6 @@ | |||
| <artifactId>graphiql-spring-boot-starter</artifactId> | |||
| <version>${graphiql-spring-boot.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I couldn't see any uses for this. Removing doesn't cause any test issues here or in the couple of dependant projects I updated.
techabstraction
approved these changes
Nov 27, 2023
andykruth-ii
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream-registry PR
climodule. Talking direct to the underlying kafka topic is no longer reccomended.Note
There is one CVE still present,
plexus-utils. This is only used by thestream-registry-graphql-maven-pluginand doesn't make it into production code.Ideally we'd want to upgrade to a newer
maven-plugin-api, but I haven't investigated if that would require users to run on a later version of maven so this is left for now.PR Checklist Forms