Merge pull request #56275 from Expensify/andrew-rm-firebase-dist

[No QA]Remove Firebase distribution as QA does not use it anymore
Expensify · Feb 3, 2025 · f6a9ce8 · f6a9ce8
2 parents 7f27b5a + 1b8a1e5
commit f6a9ce8
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 29 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -252,10 +252,6 @@ jobs:
           name: android-hybrid-apk-artifact
           path: Expensify.apk
 
-      - name: Upload Android build to Firebase distribution
-        if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
-        run: bundle exec fastlane android upload_firebase_distribution
-
       - name: Upload Android build artifact
         if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
         uses: actions/upload-artifact@v4
@@ -577,10 +573,6 @@ jobs:
         env:
           BROWSERSTACK: ${{ secrets.BROWSERSTACK }}
 
-      - name: Upload iOS build to Firebase distribution
-        if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
-        run: bundle exec fastlane ios upload_firebase_distribution
-
       - name: Upload iOS build artifact
         if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
         uses: actions/upload-artifact@v4

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -197,17 +197,6 @@ platform :android do
     )
   end
 
-  desc "Upload app to Firebase distribution"
-    lane :upload_firebase_distribution do
-      firebase_app_distribution(
-          app: "1:1008697809946:android:2e48f9ffe8d0b6a2",
-          service_credentials_file: "./firebase.json",
-          groups: "applause",
-          android_artifact_path: ENV[KEY_GRADLE_AAB_PATH],
-          android_artifact_type: "AAB"
-      )
-    end
-
     desc "Upload HybridApp to Google Play for internal testing"
     lane :upload_google_play_internal_hybrid do
       # Google is very unreliable, so we retry a few times
@@ -518,16 +507,6 @@ platform :ios do
     sh("echo '{\"ipa_path\": \"#{lane_context[SharedValues::S3_IPA_OUTPUT_PATH]}\",\"html_path\": \"#{lane_context[SharedValues::S3_HTML_OUTPUT_PATH]}\"}' > ../ios_paths.json")
   end
 
-  desc "Upload app to Firebase distribution"
-    lane :upload_firebase_distribution do
-      firebase_app_distribution(
-          app: "1:1008697809946:ios:3ffad71f664f2886",
-          service_credentials_file: "./firebase.json",
-          groups: "applause",
-          ipa_path: ENV[KEY_IPA_PATH],
-      )
-    end
-
   desc "Upload app to TestFlight"
   lane :upload_testflight do
     upload_to_testflight(