Handle std::out_of_range exception thrown in getMarkdownWorklet on iOS
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When parser worklet is not found,
.at()method throwsstd::out_of_rangeexception which currently crashes the app. This PR addstry/catchblock aroundexpensify::livemarkdown::getMarkdownWorklet()call in MarkdownParser.mm. After this change, we will skip formatting instead of crashing the app. This is only a partial fix to unify iOS and Android implementation in their current shapes. The root cause will be addressed separately.Related Issues
Partially fixes #609.
Manual Tests
Linked PRs