Merge pull request #498 from Expensify/revert-480-fix/falsey-value-is…

…-ignored Revert "Re: Use initialValue when cached value is undefined"
Expensify · Mar 5, 2024 · 3e9b790 · 3e9b790
2 parents a489f47 + 8c9e9f2
commit 3e9b790
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/lib/withOnyx.js b/lib/withOnyx.js
@@ -59,7 +59,7 @@ export default function (mapOnyxToState, shouldDelayUpdates = false) {
                     (resultObj, mapping, propertyName) => {
                         const key = Str.result(mapping.key, props);
                         let value = Onyx.tryGetCachedValue(key, mapping);
-                        if (value === undefined) {
+                        if (!value && mapping.initialValue) {
                             value = mapping.initialValue;
                         }
 

diff --git a/tests/unit/withOnyxTest.js b/tests/unit/withOnyxTest.js
@@ -561,10 +561,6 @@ describe('withOnyxTest', () => {
                         key: ONYX_KEYS.SIMPLE_KEY,
                         initialValue: 'initialValue',
                     },
-                    simple2: {
-                        key: ONYX_KEYS.SIMPLE_KEY_2,
-                        initialValue: false,
-                    },
                 })(ViewWithCollections);
                 render(
                     <TestComponentWithOnyx
@@ -582,7 +578,6 @@ describe('withOnyxTest', () => {
                     onRender,
                     testObject: {isDefaultProp: true},
                     simple: 'initialValue',
-                    simple2: false,
                 });
             });
     });