Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add GET route for event records #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ibinola
Copy link
Contributor

@Ibinola Ibinola commented Jan 23, 2025

Closes - #43

Copy link
Contributor

@Ugo-X Ugo-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove yarn lock from the commit history

id: number;
title: string;
description: string;
category: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-24 at 09 04 01 Screenshot 2025-01-24 at 09 04 09

lets fix this.

description: string;
category: string;
date: string;
participants: Participant[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-24 at 09 38 06

make it match this event details component.

Screenshot 2025-01-24 at 09 35 27

here is the create component used to create an event

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@Ibinola
Copy link
Contributor Author

Ibinola commented Jan 24, 2025

for the user participation? do i leave in the participants field ? @Ugo-X , the event details doesn't have one for participants, so how do i factor that in

@Ugo-X
Copy link
Contributor

Ugo-X commented Jan 24, 2025

for the user participation? do i leave in the participants field ? @Ugo-X , the event details doesn't have one for participants, so how do i factor that in

could you hold for a while so that the create event api is done?
by then, you can take a look at it and finish up

@Ibinola
Copy link
Contributor Author

Ibinola commented Jan 24, 2025

for the user participation? do i leave in the participants field ? @Ugo-X , the event details doesn't have one for participants, so how do i factor that in

could you hold for a while so that the create event api is done? by then, you can take a look at it and finish up

alright no problem, i can wait

@Ugo-X
Copy link
Contributor

Ugo-X commented Jan 26, 2025

#49

Please refer to the PR above and refactor accordingly and make use of the model he provided in his PR, his tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants