Move configs from setup.py to setup.cfg #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves configs from
setup.pytosetup.cfgin similar to neulab/ExplainaBoard#516 (for neulab/ExplainaBoard#490). Also, the command to install spaCy's English pipeline is documented in README.md and added to CI to run tests.Note that comments for requirements were removed because setuptools doesn't support adding inline comments. I'm not sure whether the current comments need to be moved to setup.cfg as well.
For details of the syntax of setup.cfg, see the documentation of setuptools.