More package options #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grusell
commented
Sep 3, 2024
grusell
commented
- chore: update Dockerfile with stage without VOLUME definition
- feat: make stream keys used in packaging configurable through env variables
- feat: add support for configuring package format through env variable PACKAGE_FORMAT_OPTIONS_JSON
- feat: make output folder structure configurable with OUTPUT_SUBFOLDER_TEMPLATE env variable
The VOLUME definition may not be needed in most cases, and could clutter up diskspace since volumes are note deleted by default when container exits. It was decided to leave the volume in the default target of the Dockerfile, but create a previous stage without VOLUME that is used for building image for dockerhub. Signed-off-by: Gustav Grusell <[email protected]>
… PACKAGE_FORMAT_OPTIONS_JSON Signed-off-by: Gustav Grusell <[email protected]>
…iables Signed-off-by: Gustav Grusell <[email protected]>
…_TEMPLATE env variable Signed-off-by: Gustav Grusell <[email protected]>
Signed-off-by: Gustav Grusell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.