feat/filter audio languages base in input #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgtfishtank
force-pushed
the
feat/use-audio-tracks
branch
from
0e7b064
to
1bc6423
Compare
Sgtfishtank
changed the title
added 7 commits
August 27, 2023 23:03
|
What has been done?
What is left to do?
|
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So currently when we are generating audio sequences we are generating one for all languages present in the Vod, but when this library is used in conjunction with Eyevinn Channel Engine it might not be necessary. Channel engine specifies a list of languages that will be used, but the list is not passed to this library so we are creating potentially unnecessary segments.
This branch aims to solve that issue by accepting a list of audio languages in the options when creating a new instance of this library. The option is optional and if not provided all languages will be created. If the Vod doesn't contain any of the languages provided in the list, the first available one will be selected instead so as to not cause any problems when playing back the Vod.