Feat/add productions list to manage view #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinstark
reviewed
Jul 1, 2024
| The production ID could not be fetched. {productionFetchError.name}{" "} | ||
| {productionFetchError.message}. | ||
| </FetchErrorMessage> | ||
| {cachedProduction && !showProductionsList && ( |
There was a problem hiding this comment.
i don't think you need to check cachedProduction here? it seems unrelated to the productions list
or is the intention that it should show/hide the list depending on if the user has entered a production id?
…ed list into its own component
…error-messages and messangers
malmen237
force-pushed
the
feat/add-productions-list-to-manage-view
branch
from
7f959b3
to
1d5c88f
Compare
|
This solution was also in PR #189 that has been merged, making this one obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Layout!
First view:
Now all productions are displayed.
When selected a production:
Either by clicking on one off the list-items or by writing a fetchable production-id
