Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/clean mv layout input #54

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Feat/clean mv layout input #54

merged 5 commits into from
Oct 25, 2024

Conversation

malmen237
Copy link

What does this do?

New default layout

On start the default layout is prepopulated with the sources from the production-setup. The slots that have not been populated is returned empty.
Screenshot 2024-10-25 at 10 13 37

Possible to have a completely clean layout

When box is ticked the layout is cleaned, when unclicked again the default layout is returned into view
Screenshot 2024-10-25 at 10 13 53

Bug-fixes

  • When removing sources on running production the multiview will return an empty view with empty label. ID is saved so if the source is added again it will reappear in multiview.
  • Restructure of how multiview is updated both on production start and on production.active

Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, but some I think are more important, eg. variable name asd

@malmen237 malmen237 requested a review from Saelmala October 25, 2024 11:45
@malmen237 malmen237 merged commit 4fa9bf8 into main Oct 25, 2024
4 checks passed
@malmen237 malmen237 deleted the feat/clean-mv-layout-input branch October 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants