forked from OwnZones/orchestration-gui
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/clean mv layout input #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
reviewed
Oct 25, 2024
src/components/modal/configureMultiviewModal/MultiviewLayoutSettings/RemoveLayoutButton.tsx
Outdated
Show resolved
Hide resolved
Saelmala
reviewed
Oct 25, 2024
Saelmala
reviewed
Oct 25, 2024
Saelmala
reviewed
Oct 25, 2024
LucasMaupin
approved these changes
Oct 25, 2024
...components/modal/configureMultiviewModal/MultiviewLayoutSettings/MultiviewLayoutSettings.tsx
Outdated
Show resolved
Hide resolved
...components/modal/configureMultiviewModal/MultiviewLayoutSettings/MultiviewLayoutSettings.tsx
Outdated
Show resolved
Hide resolved
Saelmala
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments, but some I think are more important, eg. variable name asd
…ttings/MultiviewLayoutSettings.tsx Co-authored-by: Lucas Maupin <[email protected]>
Saelmala
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
New default layout
On start the default layout is prepopulated with the sources from the production-setup. The slots that have not been populated is returned empty.

Possible to have a completely clean layout
When box is ticked the layout is cleaned, when unclicked again the default layout is returned into view

Bug-fixes