Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ purge bugs in sourcelist #58

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

malmen237
Copy link

What does this do?

Not showing purged items

A condition had been removed, so that purged items was shown in inventory-list and in source-list.

Sources was resetting to "gone"

During syncInventory status "purge" was being reset to "gone" if item was missing from API-fetch.

Fetch error-message in log

Excessive error-message in dev log when image-was missing from source-list.

Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM!

@malmen237 malmen237 merged commit bf147a5 into main Oct 29, 2024
4 checks passed
@malmen237 malmen237 deleted the fix/purge-bugs-in-sourcelist branch October 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants