Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tests for tracking endpoint depending on VAST version #81

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

oscnord
Copy link
Contributor

@oscnord oscnord commented Feb 1, 2024

This PR adds tests for the adId (depending on VAST version it will either be adId or adID) when using the tracking endpoint. This is nothing that requires a new release but nice to have.

@oscnord oscnord requested review from birme and Nfrederiksen February 1, 2024 15:12
@oscnord oscnord self-assigned this Feb 1, 2024
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@birme birme merged commit 1606301 into main Feb 1, 2024
2 checks passed
@birme birme deleted the feat/tests-tracking-endpoint branch February 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants